Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cups-idprt-{tspl, barcode, mt888, mt890, sp900}: init #308317

Merged
merged 5 commits into from
Aug 22, 2024
Merged

cups-idprt-{tspl, barcode, mt888, mt890, sp900}: init #308317

merged 5 commits into from
Aug 22, 2024

Conversation

Pandapip1
Copy link
Contributor

@Pandapip1 Pandapip1 commented May 1, 2024 •
edited
Loading

Description of changes

Closes #306560

Adds printer drivers for many iDPRT printers.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label May 1, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 1, 2024
@Pandapip1 Pandapip1 marked this pull request as ready for review May 1, 2024 17:31
@Pandapip1
Copy link
Contributor Author

CI recommended I put this in pkgs/by-name/cu/cups-idprt/package.nix instead of pkgs/misc/cups/drivers/cups-idprt/default.nix. Can I confirm that this is preferred?

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 1, 2024
@github-actions github-actions bot removed the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label May 1, 2024
@NickCao
Copy link
Member

NickCao commented May 2, 2024

Can I confirm that this is preferred?

Yes.

@Pandapip1
Copy link
Contributor Author

Just E2E tested. It works!

@Pandapip1 Pandapip1 requested a review from Sigmanificient May 9, 2024 19:52
@Pandapip1 Pandapip1 requested a review from Sigmanificient May 9, 2024 20:51
Sigmanificient
Sigmanificient suggested changes Jun 5, 2024
View reviewed changes
pkgs/by-name/cu/cups-idprt/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/cu/cups-idprt/package.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 5, 2024
@Pandapip1 Pandapip1 requested a review from Sigmanificient July 24, 2024 10:04
@Pandapip1 Pandapip1 force-pushed the init-cups-idprt branch 3 times, most recently from f59da40 to 5cb523f Compare August 11, 2024 23:35
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4392

@Pandapip1 Pandapip1 force-pushed the init-cups-idprt branch 3 times, most recently from 1e764d4 to 291c9cc Compare August 18, 2024 15:18
@Pandapip1 Pandapip1 changed the title cups-idprt: init 1.4.2 cups-idprt-tspl: init 1.4.7 Aug 18, 2024
@Pandapip1 Pandapip1 changed the title cups-idprt-tspl: init 1.4.7 cups-idprt-{tspl, mt888, mt890, sp900}: init Aug 18, 2024
@Pandapip1 Pandapip1 changed the title cups-idprt-{tspl, mt888, mt890, sp900}: init cups-idprt-{tspl, barcode, mt888, mt890, sp900}: init Aug 18, 2024
@SuperSandro2000 SuperSandro2000 merged commit 27b27e5 into NixOS:master Aug 22, 2024
25 of 26 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request Aug 22, 2024
Merged
1 task
@Pandapip1 Pandapip1 deleted the init-cups-idprt branch August 22, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Misterio77 Misterio77 Awaiting requested review from Misterio77

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@adamcstephens adamcstephens Awaiting requested review from adamcstephens

@bendlas bendlas Awaiting requested review from bendlas

@emilylange emilylange Awaiting requested review from emilylange

@stigtsp stigtsp Awaiting requested review from stigtsp

@zakame zakame Awaiting requested review from zakame

@dasJ dasJ Awaiting requested review from dasJ

@marcusramberg marcusramberg Awaiting requested review from marcusramberg

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@Sigmanificient Sigmanificient Awaiting requested review from Sigmanificient

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: cups-idprt
6 participants
@Pandapip1 @NickCao @Sigmanificient @nixos-discourse @Misterio77 @SuperSandro2000